Add Apache license headers to fix ATR concerns - #12613
Conversation
Add missing Apache License headers to files flagged by ATR: - Java test files (MyMojoTest.java, App.java, AppTest.java) - Shell script (prepare.sh) - Config files (Jenkinsfile, .asf.yaml) - Service loader files (Processor, di.Inject) - Test pom/metadata XML files in inheritance-repo - Test placeholder files Binary .jar files and third-party license texts (EPL, CDDL, BSD) remain without headers as they cannot be modified. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
Looks good. Mechanical addition of standard Apache License headers across 87 files to address ATR release-review concerns. All headers are correct, properly positioned, and use appropriate comment syntax per file type (/* */ for Java/Groovy, # for YAML/SPI/shell, <!-- --> for XML, plain text for .txt).
A few minor observations (all benign):
- Jenkinsfile — The
#!groovyshebang was removed. Modern Jenkins Declarative Pipeline doesn't require it, so this is safe. - NOTICE — URL changed from
httptohttps— good modernization, though outside the stated scope. - AppTest.java (test resource fixture) — Import statements were reordered. No functional impact.
All XML files correctly preserve <?xml?> declarations on line 1 with license headers placed after. Shell script preserves shebang. SPI service loader files use valid #-style comments per the ServiceLoader spec.
(Posting as COMMENT because GitHub does not allow self-approval — this would otherwise be an APPROVE.)
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
|
@gnodet Please assign appropriate label to PR according to the type of change. |
Add missing Apache License headers to files flagged by ATR: - Java test files (MyMojoTest.java, App.java, AppTest.java) - Shell script (prepare.sh) - Config files (Jenkinsfile, .asf.yaml) - Service loader files (Processor, di.Inject) - Test pom/metadata XML files in inheritance-repo - Test placeholder files Binary .jar files and third-party license texts (EPL, CDDL, BSD) remain without headers as they cannot be modified. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 participant
Summary
Add missing Apache License headers to files flagged by ATR (Apache Trusted Releases) during the rc-6 release review.
MyMojoTest.java,App.java,AppTest.java— added standard ASF license headerprepare.sh— added#-style license header after shebangJenkinsfile,.asf.yaml— added license headersjavax.annotation.processing.Processor,org.apache.maven.api.di.Inject— added#-comment license headers (valid per SPI spec).pom,pom.xml, andmaven-metadata.xmlfiles incompat/maven-compat/src/test/resources/inheritance-repo/andsrc/test/remote-repo/— added XML comment license headersplaceholder.txt— added plain text license headerRemaining ATR concerns (cannot be fixed):
.jarfiles (~50 files in test resources) — cannot add text headers to binary filesEPL-1.0.txt,CDDL+GPLv2-with-classpath-exception.txt, etc.) — cannot add Apache header to third-party licensesBad.java— intentionally invalid Java file for MNG-5208 testsource.txt— test asserts exact"Hello World!"on first lineThese remaining items are already excluded in the Maven Rat plugin configuration and are standard false positives.
Test plan
mvn verifystill passes (XML comment headers are ignored by Maven's POM parser)compat/maven-compatstill pass🤖 Generated with Claude Code